Implement multi version for apiref #4190
Merged
+52
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
rikatz
force-pushed
the
multi-version-apiref
branch
2 times, most recently
from
b1b95ba to
e0bc4a4
Compare
|
Like this PR, but could we add the update steps into Aside from that, this LGTM. |
|
Awesome, I’ve been waiting for this feature, thanks, @rikatz. |
rikatz
force-pushed
the
multi-version-apiref
branch
from
e0bc4a4 to
c35e936
Compare
|
@youngnick fixed |
|
/cc @youngnick @robscott |
|
Thanks @rikatz! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
This is great, thanks @rikatz! /lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This is an attempt to implement multiversion for our API Reference.
While it is very "rudimentary", it allows us to set different versions of API on the navigation bar.
The rationale about keeping just the current versions (1.3, 1.4 and main) is because before 1.3 we didn't had experimental APIs and I've tried to not overcomplicate it.
Once a new release is cut, the release manager or some contributor must:
generate.shto add the new branchWhich issue(s) this PR fixes:
Fixes #4151
Does this PR introduce a user-facing change?: